Skip to content

chore(helm): define pod probes#1960

Closed
adamantal wants to merge 1 commit intorobusta-dev:masterfrom
adamantal:master
Closed

chore(helm): define pod probes#1960
adamantal wants to merge 1 commit intorobusta-dev:masterfrom
adamantal:master

Conversation

@adamantal
Copy link
Contributor

@adamantal adamantal commented Nov 20, 2025

Description

When robusta starts, the pod becomes healthy immediately. After a few seconds, it loads the config and the pydantic validations run on those configs. If there's an error, the container can immediately fail leaving no running robusta pod behind (not good).

If we want to make sure the rolling our a new version is graceful, we can define a readiness probe or even just a bit of a delay (to wait a few seconds until robusta loads the configs, making sure there's no validation error here).

Testing

Currently in progress

@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5fa727 and 6168ba0.

📒 Files selected for processing (2)
  • docs/playbook-reference/prometheus-examples/link-alert-enrichment.rst
  • playbooks/robusta_playbooks/alerts_integration.py

Walkthrough

Introduces a new optional required_label parameter to the button enricher that conditionally adds buttons based on alert label presence. When specified, buttons are only added if the corresponding label exists and is non-empty. Includes documentation example and implementation updates.

Changes

Cohort / File(s) Summary
Button enricher required_label feature
docs/playbook-reference/prometheus-examples/link-alert-enrichment.rst, playbooks/robusta_playbooks/alerts_integration.py		 Added optional required_label field to TemplatedButtonParams class with conditional button enrichment logic that skips adding buttons when the specified label is missing or empty. Updated YAML documentation example.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • robusta#1943: Introduced the initial button_enricher feature that is extended by this PR with label-based conditional logic.

Suggested reviewers

  • arikalon1

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(helm): define pod probes' accurately summarizes the main change, which adds readiness and liveness probes to the Helm chart.
Description check ✅ Passed The description clearly explains the problem (pod becomes healthy before config validation) and the solution (adding probes), directly relating to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adamantal adamantal closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adamantal